Accueil > Contributions > Shnoulle (Denis Chenu) · GitHub
Shnoulle has repositories on Github. Follow their code on GitHub.
Articles
-
Shnoulle commented on pull request LimeSurvey/LimeSurvey#3759
27 février, par ShnoulleShnoulle commented on LimeSurvey/LimeSurvey#3759 · February 27, 2024 08:58 Shnoulle commented Feb 27, 2024 we get: Yes, but you pit the echo at the place you want … This was the reason behind the change Yes : i understand this, but since both call u… -
Shnoulle commented on pull request LimeSurvey/LimeSurvey#3759
27 février, par ShnoulleShnoulle commented on LimeSurvey/LimeSurvey#3759 · February 27, 2024 08:54 Shnoulle commented Feb 27, 2024 My opinion : currently : aPermissionStatic is badly used : we really need to use it before. And it improve whol epermission system :) -
Shnoulle commented on pull request LimeSurvey/LimeSurvey#3759
27 février, par ShnoulleShnoulle commented on LimeSurvey/LimeSurvey#3759 · February 27, 2024 08:46 Shnoulle commented Feb 27, 2024 But isn't this sounding like bad design? Do we need to execute permission check for permissions that we already checked? Do we know of examples of… -
Shnoulle commented on pull request LimeSurvey/LimeSurvey#3761
27 février, par ShnoulleShnoulle commented on LimeSurvey/LimeSurvey#3761 · February 27, 2024 08:39 Shnoulle commented Feb 27, 2024 htmlspecialchars($surveyName) . '-[' . $surveyId . ']/[' . $page . ']-' . htmlspecialchars($groupName) Maybe use Chtml::encode ? -
Shnoulle commented on pull request LimeSurvey/LimeSurvey#3759
26 février, par ShnoulleShnoulle commented on LimeSurvey/LimeSurvey#3759 · February 26, 2024 15:25 Shnoulle commented Feb 26, 2024 It's an API broker : beforeHasPermission happen each time a permission is done before. I don't have plugin using this, but it can happen.